Aitozi commented on code in PR #19840:
URL: https://github.com/apache/flink/pull/19840#discussion_r900113489
##########
flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java:
##########
@@ -150,6 +150,18 @@ public class ResourceManagerOptions {
.defaultValue(Duration.ofMillis(50))
.withDescription("The delay of the resource requirements
check.");
+ /**
+ * The long delay of requirements check. This is only used for waiting for
the previous
+ * TaskManagers registration and will only take effect in the first
requirements check.
+ */
+ public static final ConfigOption<Duration> REQUIREMENTS_CHECK_LONG_DELAY =
+ ConfigOptions.key("slotmanager.requirement-check.long-delay")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(3))
Review Comment:
Yes, I think we could add a conservative default value 1s, and add
description to let user know: if redundant TaskManager are launched during the
JobManager failover, we could increase this delay to solve it.
How do you think ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
