Aitozi commented on code in PR #19840:
URL: https://github.com/apache/flink/pull/19840#discussion_r900711478
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java:
##########
@@ -504,8 +522,11 @@ private void checkResourceRequirementsWithDelay() {
Preconditions.checkNotNull(requirementsCheckFuture)
.complete(null);
}),
- requirementsCheckDelay.toMillis(),
+ delay,
TimeUnit.MILLISECONDS);
+ isRequirementsCheckLongDelay = false;
+ } else {
+ checkResourceRequirements();
Review Comment:
BTW, I found that the two slot manager have the exactly same method
`checkResourceRequirementsWithDelay`. Do we need to add a abstract class to put
it to avoid the duplicated methods ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
