zentol commented on code in PR #19968:
URL: https://github.com/apache/flink/pull/19968#discussion_r900223182
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java:
##########
@@ -132,6 +146,7 @@ public void onLeave(Class<? extends State> newState) {
@Override
public void cancel() {
+ operationFailureCause = new FlinkException("The job was cancelled.");
Review Comment:
not waiting can cause bad things to happen when the SP completes during
cancellation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]