zentol commented on code in PR #19968:
URL: https://github.com/apache/flink/pull/19968#discussion_r901377456
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepointTest.java:
##########
@@ -82,7 +82,9 @@ void testJobFailed() throws Exception {
try (MockStopWithSavepointContext ctx = new
MockStopWithSavepointContext()) {
StateTrackingMockExecutionGraph mockExecutionGraph =
new StateTrackingMockExecutionGraph();
- StopWithSavepoint sws = createStopWithSavepoint(ctx,
mockExecutionGraph);
+ final CompletableFuture<String> savepointFuture =
CompletableFuture.completedFuture("");
Review Comment:
> Additionally, we should verify that a StopWithSavepointStopException is
part of the cause for this specific test case, shouldn't we?
> is that the test you're refering to in your
https://github.com/apache/flink/pull/19968#pullrequestreview-1010663103?
yes that's what I meant. The enrichment isn't explicitly covered afaict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
