reswqa commented on code in PR #19984:
URL: https://github.com/apache/flink/pull/19984#discussion_r901138718
##########
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java:
##########
@@ -27,14 +27,13 @@
import java.io.IOException;
import java.util.Collections;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
public class GlobFilePathFilterTest {
@Test
Review Comment:
```suggestion
@Test -> @org.junit.jupiter.api.Test;
```
##########
flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java:
##########
@@ -27,14 +27,13 @@
import java.io.IOException;
import java.util.Collections;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
public class GlobFilePathFilterTest {
@Test
Review Comment:
Using assertj is great, would you like to migrate this class to junit5 at
the same time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
