chenzihao5 commented on code in PR #19797:
URL: https://github.com/apache/flink/pull/19797#discussion_r903383377
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/OverAggregateITCase.scala:
##########
@@ -159,6 +159,66 @@ class OverAggregateITCase(mode: StateBackendMode) extends
StreamingWithStateTest
assertEquals(expected.sorted, sink.getAppendResults.sorted)
}
+ @Test
+ def testDenseRankOnOver(): Unit = {
Review Comment:
Hi, @xuyangzhong . Thanks for your review and sorry for delay response. I
didn't find the UT of AggFunctionFactory, so I borrowed the test for
ROW_NUMBER. And I haven't waited for the community's reply, I can add
corresponding unit tests later if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
