chenzihao5 commented on code in PR #19797:
URL: https://github.com/apache/flink/pull/19797#discussion_r903392287
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/RankLikeAggFunctionBase.java:
##########
@@ -98,7 +98,7 @@ protected Expression orderKeyEqualsExpression() {
equalTo(lasValue, operand(i)));
}
Optional<Expression> ret =
Arrays.stream(orderKeyEquals).reduce(ExpressionBuilder::and);
- return ret.orElseGet(() -> literal(true));
+ return ret.orElseGet(() -> literal(false));
Review Comment:
@xuyangzhong The default value of true will cause the sort value to be
unchanged, which I don't think conforms to the semantics of sorting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
