Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2447#discussion_r77311117
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/instance/Instance.java ---
@@ -84,22 +90,22 @@
* Constructs an instance reflecting a registered TaskManager.
*
* @param actorGateway The actor gateway to communicate with the remote
instance
- * @param connectionInfo The remote connection where the task manager
receives requests.
- * @param resourceId The resource id which denotes the resource the
task manager uses.
+ * @param location The remote connection where the task manager
receives requests.
+ * @param taskManagerId The resource id which denotes the resource the
task manager uses.
* @param id The id under which the taskManager is registered.
* @param resources The resources available on the machine.
* @param numberOfSlots The number of task slots offered by this
taskManager.
*/
public Instance(
ActorGateway actorGateway,
- InstanceConnectionInfo connectionInfo,
- ResourceID resourceId,
+ TaskManagerLocation location,
+ ResourceID taskManagerId,
--- End diff --
Isn't the resource ID part of the `TaskManagerLocation`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
