Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
Thanks for the contribution @wangzhijiang999.
I think the abstraction is not right. The `StandaloneFactory` and the
`YarnFactory` should actually only differ in the class of the `TaskExecutor`
they start. Furthermore, I think that the network interface selection should
not be part of the factory. Instead I would pass the hostname and port to the
`createTaskManager(hostname, port)` method which constructs the `TaskManager`.
Maybe it makes even sense to pass the `RpcService` via the
`createTaskManager(RpcService)` and defer the RpcService creation to the
outside method running the select interface method.
The difference between the Standalone/Yarn and Testing factory is that the
first two create the TM components whereas the `TestingFactory` is initialized
with the `TaskManager` components.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
