Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2461
Hi @wangzhijiang999, maybe we should start simple without introducing a
factory method, because there might actually be not many cases to distinguish.
Maybe we could rename the `TaskManagerFactory` into `TaskManagerRunner` which
has static methods to create the `TaskManagers` components and does the network
selection. That way we keep the initialization and the actual `TaskManager`
logic separated.
For testing purposes I guess we don't need to setup any components because
they are usually mocked or one is using testing components. Passing these
components to the constructor of the `TaskManager` should not be a big deal.
Does this make sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
