pnowojski commented on code in PR #20075:
URL: https://github.com/apache/flink/pull/20075#discussion_r908137668
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java:
##########
@@ -385,11 +385,16 @@ public Task(
shuffleEnvironment.createShuffleIOOwnerContext(
taskNameWithSubtaskAndId, executionId,
metrics.getIOMetricGroup());
+ boolean overdraftBufferEnabled =
+ !nameOfInvokableClass.equals(
+
"org.apache.flink.streaming.runtime.tasks.SourceStreamTask");
Review Comment:
I suggested it, because it encapsulates this logic inside
`SourceStreamTask`, making it easier to find and maintain. At the same time it
avoids this quite hacky and nasty
`nameOfInvokableClass.equals("org.apache.flink.streaming.runtime.tasks.SourceStreamTask");`.
So if the code is comparably complicated I would be +1 for changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
