pnowojski commented on code in PR #20075:
URL: https://github.com/apache/flink/pull/20075#discussion_r909420150
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java:
##########
@@ -164,6 +164,7 @@ public void triggerCheckpoint(long checkpointId) throws
FlinkException {
.gauge(
MetricNames.CHECKPOINT_START_DELAY_TIME,
this::getAsyncCheckpointStartDelayNanos);
+ recordWriter.setMaxOverdraftBuffersPerGate(0);
Review Comment:
Could you add a unit test for this? I think it could look similar to
`SourceStreamTaskTest#testTriggeringCheckpointAfterSourceThreadFinished` but
vastly simplified:
1. Create a single additional `ResultPartition`
2. assert `resultPartition.getBufferPool().getMaxOverdraftBuffersPerGate() >
0`
3. Construct `SourceStreamTask` via `StreamTaskMailboxTestHarnessBuilder`
4. assert `resultPartition.getBufferPool().getMaxOverdraftBuffersPerGate()
== 0`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
