zhuzhurk commented on code in PR #20057:
URL: https://github.com/apache/flink/pull/20057#discussion_r909160467


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -1023,6 +1025,19 @@ public void configure(ReadableConfig configuration, 
ClassLoader classLoader) {
                                                 
.ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH,
                                         flag));
 
+        // merge PipelineOptions.JARS, user maybe set this option in high 
level such as table
+        // module, so here need to merge the jars from both configuration 
object
+        configuration
+                .getOptional(PipelineOptions.JARS)
+                .ifPresent(
+                        jars ->
+                                ConfigUtils.mergeCollectionsToConfig(
+                                        this.configuration,
+                                        PipelineOptions.JARS,
+                                        new HashSet<>(jars),

Review Comment:
   ```suggestion
                                           
Collections.unmodifiableCollection(jars),
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to