gyfora commented on code in PR #283:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/283#discussion_r911674207
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/SessionReconciler.java:
##########
@@ -133,7 +135,16 @@ protected void rollback(FlinkDeployment deployment,
Context ctx, Configuration o
FlinkDeploymentSpec rollbackSpec =
reconciliationStatus.deserializeLastStableSpec();
Configuration rollbackConfig =
configManager.getDeployConfig(deployment.getMetadata(),
rollbackSpec);
- upgradeSessionCluster(deployment, rollbackSpec, rollbackConfig);
+
+ deleteSessionCluster(deployment, observeConfig);
+ deploy(
Review Comment:
The rollback logic doesn't assume anything about the generation etc so there
is not really a need to record it.
Also we cannot put this in `deploy` directly because deploy is used for spec
update, JM recovery, and rollback. And the target generation will only be
useful for spec change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
