gyfora commented on code in PR #283:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/283#discussion_r911677268
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -106,19 +107,27 @@ protected void reconcileSpecChange(
// We must record the upgrade mode used to the status later
currentDeploySpec.getJob().setUpgradeMode(availableUpgradeMode.get());
cancelJob(resource, availableUpgradeMode.get(), observeConfig);
- newState = JobState.SUSPENDED;
+ if (desiredJobState == JobState.RUNNING) {
+
ReconciliationUtils.updateStatusBeforeDeploymentAttempt(resource, deployConfig);
Review Comment:
It is simpler to keep it in updating state here because that affects how
stable spec is updated for suspended deployments + the immediate reconcile
delay. Eliminating this if branch would mean making another 3 methods more
complicated :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
