rmetzger commented on code in PR #20117:
URL: https://github.com/apache/flink/pull/20117#discussion_r913079148
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java:
##########
@@ -1853,6 +1853,7 @@ private <OUT> DataStreamSource<OUT> createFileInput(
SingleOutputStreamOperator<OUT> source =
addSource(monitoringFunction, sourceName, null, boundedness)
+
.setMaxParallelism(CoreOptions.DEFAULT_PARALLELISM.defaultValue())
Review Comment:
I believe using the default value here is not correct. Imagine we are
changing the default parallelism to 10 for some weird reason in the future,
then this source would break.
Maybe introduce a new constant
`ContinuousFileMonitoringFunction.MAX_PARALLELISM = 1` ?
I also think it would be good to add a comment explaining why this is
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
