MartijnVisser commented on code in PR #20127:
URL: https://github.com/apache/flink/pull/20127#discussion_r913673950
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvCommons.java:
##########
@@ -35,6 +35,7 @@
import static
org.apache.flink.formats.csv.CsvFormatOptions.IGNORE_PARSE_ERRORS;
import static org.apache.flink.formats.csv.CsvFormatOptions.NULL_LITERAL;
import static org.apache.flink.formats.csv.CsvFormatOptions.QUOTE_CHARACTER;
+import static
org.apache.flink.formats.csv.CsvFormatOptions.WRITE_BIGDECIMAL_AS_PLAIN;
Review Comment:
@afedulov or @PatrickRen any opinions about this solution implementation?
##########
docs/content.zh/docs/connectors/table/formats/csv.md:
##########
@@ -29,18 +29,17 @@ under the License.
{{< label "Format: Serialization Schema" >}}
{{< label "Format: Deserialization Schema" >}}
-[CSV](https://zh.wikipedia.org/wiki/%E9%80%97%E5%8F%B7%E5%88%86%E9%9A%94%E5%80%BC)
Format 允许我们基于 CSV schema 进行解析和生成 CSV 数据。 目前 CSV schema 是基于 table schema 推断而来的。
Review Comment:
You have updated the Chinese documentation with English content. The English
content can be found in `docs/content/docs/connectors/table/formats/csv.md` -
Please make sure that at least the English one has the right documentation
##########
docs/content.zh/docs/connectors/table/formats/csv.md:
##########
@@ -3,7 +3,7 @@ title: CSV
weight: 2
type: docs
aliases:
- - /zh/dev/table/connectors/formats/csv.html
+- /dev/table/connectors/formats/csv.html
Review Comment:
Please revert, the original value was correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
