tsreaper commented on code in PR #201:
URL: https://github.com/apache/flink-table-store/pull/201#discussion_r914621187
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/CatalogFactory.java:
##########
@@ -34,9 +34,9 @@ public interface CatalogFactory {
String identifier();
- Catalog create(String warehouse, ReadableConfig options);
+ Catalog create(String warehouse, Configuration options);
- static Catalog createCatalog(ReadableConfig options) {
+ static Catalog createCatalog(Configuration options) {
// manual validation
Review Comment:
Now that we have a dedicated `CatalogOptions` class to hold all options, we
can call the `validate` method and add those options into required or optional
methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
