JingsongLi commented on code in PR #201:
URL: https://github.com/apache/flink-table-store/pull/201#discussion_r914635219
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/CatalogFactory.java:
##########
@@ -34,9 +34,9 @@ public interface CatalogFactory {
String identifier();
- Catalog create(String warehouse, ReadableConfig options);
+ Catalog create(String warehouse, Configuration options);
- static Catalog createCatalog(ReadableConfig options) {
+ static Catalog createCatalog(Configuration options) {
// manual validation
Review Comment:
I think we can let it go
If there is a situation where you need to configure some HiveClient
parameters, you can do so through this channel.
At the beginning we can be a little more flexible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
