luoyuxia commented on code in PR #19561:
URL: https://github.com/apache/flink/pull/19561#discussion_r914822644
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveParserDDLSemanticAnalyzer.java:
##########
@@ -506,6 +533,109 @@ private Operation convertCreateFunction(HiveParserASTNode
ast) {
}
}
+ private Operation convertCreateMacro(HiveParserASTNode ast) throws
SemanticException {
+ String macroName = ast.getChild(0).getText();
+ if (FunctionUtils.isQualifiedFunctionName(macroName)) {
+ throw new SemanticException("The name of the temporary macro can't
contain `.`.");
Review Comment:
I add the test for the exception in
[HiveDialectITCase#testMacro](https://github.com/apache/flink/pull/19561/files#diff-748a9fa63f15b3bd3ea5426a5b42179cadee77ecf3359c83f846aedb27d96871R821)
just now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
