deadwind4 commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/23#discussion_r914925778
##########
docs/content/docs/connectors/datastream/elasticsearch.md:
##########
@@ -226,17 +226,60 @@ To use fault tolerant Elasticsearch Sinks, checkpointing
of the topology needs t
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+
+Elasticsearch 6:
+```java
+final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // checkpoint every 5000 msecs
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
Review Comment:
I found the Chinese translations of `IMPORTANT: Checkpointing is not enabled
by default but ....... ` was deleted and the example of the fault tolerance
section in the English doc wasn't updated in this former commit.
##########
docs/content/docs/connectors/datastream/elasticsearch.md:
##########
@@ -226,17 +226,60 @@ To use fault tolerant Elasticsearch Sinks, checkpointing
of the topology needs t
{{< tabs "d00d1e93-4844-40d7-b0ec-9ec37e73145e" >}}
{{< tab "Java" >}}
+
+Elasticsearch 6:
+```java
+final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+env.enableCheckpointing(5000); // checkpoint every 5000 msecs
+
+Elasticsearch6SinkBuilder sinkBuilder = new Elasticsearch6SinkBuilder<String>()
+ .setDeliveryGuarantee(DeliveryGuarantee.AT_LEAST_ONCE)
+ .setHosts(new HttpHost("127.0.0.1", 9200, "http"))
+ .setEmitter(
+ (element, context, indexer) ->
+ indexer.add(createIndexRequest(element)));
Review Comment:
I found the Chinese translations of `IMPORTANT: Checkpointing is not enabled
by default but .......` was deleted and the example of the fault tolerance
section in the English doc wasn't updated in this former commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
