swuferhong commented on code in PR #20084:
URL: https://github.com/apache/flink/pull/20084#discussion_r915829129
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceBuilder.java:
##########
@@ -315,7 +315,7 @@ private RowType getProducedRowType() {
return (RowType)
producedSchema.toRowDataType().bridgedTo(RowData.class).getLogicalType();
}
- private BulkFormat<RowData, HiveSourceSplit> createDefaultBulkFormat() {
+ public BulkFormat<RowData, HiveSourceSplit> createDefaultBulkFormat() {
Review Comment:
> ditto
I think this modify is necessary. Because $createDefaultBulkFormat() can
only used by $buildWithDefaultBulkFormat(), however
$buildWithDefaultBulkFormat() a HiveSource not a BulkFormat. So, it should be a
public method which can be used to create default bulk format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
