gyfora commented on code in PR #302:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/302#discussion_r916555598


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/TestUtils.java:
##########
@@ -421,6 +427,28 @@ public static void setEnv(Map<String, String> newEnv) {
         }
     }
 
+    public static <T extends AbstractFlinkResource<?, ?>> MetricManager<T> 
createTestMetricManager(

Review Comment:
   The MetricListener doesn't expose the registry and also it hardcodes a base 
group, so I had to remove it from our tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to