gyfora commented on code in PR #302:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/302#discussion_r916566646
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/StatusRecorderTest.java:
##########
@@ -70,49 +74,64 @@ public void testPatchOnlyWhenChanged() throws
InterruptedException {
@Test
public void testFlinkDeploymentMetrics() throws InterruptedException {
- var metricListener = new MetricListener();
+ var metrics = new HashMap<String, Metric>();
Review Comment:
It's not very easy to use for these simple tests due to some hardcoded/not
exposed logic. I added a more details in the other comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
