nferrario commented on code in PR #117:
URL: https://github.com/apache/flink-docker/pull/117#discussion_r916719544


##########
1.15/scala_2.12-java11-debian/docker-entrypoint.sh:
##########
@@ -91,7 +91,12 @@ prepare_configuration() {
 
 maybe_enable_jemalloc() {
     if [ "${DISABLE_JEMALLOC:-false}" == "false" ]; then
-        export LD_PRELOAD=$LD_PRELOAD:/usr/lib/x86_64-linux-gnu/libjemalloc.so
+        # Maybe use export LD_PRELOAD=$LD_PRELOAD:/usr/lib/$(uname 
-i)-linux-gnu/libjemalloc.so
+        if [[ `uname -i` == 'aarch64' ]]; then
+            export 
LD_PRELOAD=$LD_PRELOAD:/usr/lib/aarch64-linux-gnu/libjemalloc.so

Review Comment:
   Considering we already get the error I posted in the first PR comment as the 
very first line of the Job Manager and Task Manager docker logs, Idk how much 
more it would help to add more warnings. It already is a very low level thing 
that you won't be able to notice unless you specifically look for it, because 
there's no way to know that Jemalloc isn't being used (it took months for us to 
realize).
   I will however add a message that's easier to understand, since the default 
LD_PRELOAD error still requires the user to look at the source code or the 
Docker image structure at the very least.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to