rkhachatryan commented on PR #20091: URL: https://github.com/apache/flink/pull/20091#issuecomment-1184265463
Thanks a lot for your analysis @gaoyunhaii! I think we can distinguish these cases in different ways: 1. [`checkNoPartlyOperatorsFinishedVertexUsedUnionListState`](https://github.com/apache/flink/blob/74f90d722f7be5db5298b84626935a585391f0df/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlan.java#L186) returns a result value (e.g. `boolean`) which then is checked in call hierarchy 2. [`checkNoPartlyOperatorsFinishedVertexUsedUnionListState`](https://github.com/apache/flink/blob/74f90d722f7be5db5298b84626935a585391f0df/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlan.java#L186) throws a `CheckpointException` with a new reason (and not wrapping in [`CheckpointCoordinator.finalizeCheckpoint`](https://github.com/apache/flink/blob/74f90d722f7be5db5298b84626935a585391f0df/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L1361)) 3. [`checkNoPartlyOperatorsFinishedVertexUsedUnionListState`](https://github.com/apache/flink/blob/74f90d722f7be5db5298b84626935a585391f0df/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlan.java#L186) throws a new type of exception; then in [`CheckpointCoordinator.finalizeCheckpoint`](https://github.com/apache/flink/blob/74f90d722f7be5db5298b84626935a585391f0df/flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java#L1361) we use a different failure reason for this type of exception (1) seems the cleanest way but requires more changes (4 calls) (2) might have some unanticipated consequences because of changing the exception type (3) seems a good compromise between invasiveness and cleanliness So I'd implement (3) or (1), WDYT? @JesseAtSZ , @gaoyunhaii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
