Aitozi commented on code in PR #20256:
URL: https://github.com/apache/flink/pull/20256#discussion_r921840763
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java:
##########
@@ -418,6 +443,30 @@ private void tryResetWorkerCreationCoolDown() {
}
}
+ @Override
+ public CompletableFuture<Acknowledge> getRecoveryFuture() {
+ return recoveryFuture;
+ }
+
+ private void tryRemovePreviousPendingRecoveryTaskManager(ResourceID
resourceID, String reason) {
+ long sizeBeforeRemove = previousAttemptUnregisteredWorkers.size();
+ boolean exist = previousAttemptUnregisteredWorkers.remove(resourceID);
+ if (exist) {
+ if (!recoveryFuture.isDone()) {
Review Comment:
`exist` indicates the count have changed, if count not change, we do not
have to do check the size change condition. I move the
`!recoveryFuture.isDone()` to the inner if to make the log more suitable. The
resource manager will be ready to serve on the timeout or all the worker
recovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
