xintongsong commented on code in PR #20256:
URL: https://github.com/apache/flink/pull/20256#discussion_r922991336


##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/active/ActiveResourceManager.java:
##########
@@ -244,6 +253,20 @@ public void 
onPreviousAttemptWorkersRecovered(Collection<WorkerType> recoveredWo
                     "Worker {} recovered from previous attempt.",
                     resourceId.getStringWithMetadata());
         }
+        if (recoveredWorkers.size() > 0) {
+            scheduleRunAsync(
+                    () -> {
+                        if (!readyToServeFuture.isDone()) {
+                            readyToServeFuture.complete(null);
+                            log.info(
+                                    "Timeout to wait recovery taskmanagers, 
recovery future is completed");
+                        }
+                    },
+                    previousWorkerRecoverTimeout.getSeconds(),
+                    TimeUnit.SECONDS);

Review Comment:
   ```suggestion
                       previousWorkerRecoverTimeout.toMillis(),
                       TimeUnit.MILLISECONDS);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to