pnowojski commented on code in PR #20233:
URL: https://github.com/apache/flink/pull/20233#discussion_r925312733
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java:
##########
@@ -121,15 +141,28 @@ public void testAbortIgnoresMissing() throws Exception {
runWithSyncWorker(this::callAbort);
}
+ @Test
+ public void testOldCheckpointIsAborted() {
Review Comment:
Aren't we missing a test coverage for the main point of this bug? That the
following sequence:
```
callAbort(1, ...);
callStart(1, ...);
```
also leads to a completed `ChannelStateWriteResult`? Previously that would
create an uncompleted `ChannelStateWriteResult`, that was causing a deadlocks
in FLINK-26803 right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
