pnowojski commented on code in PR #20233:
URL: https://github.com/apache/flink/pull/20233#discussion_r930705894


##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriterImplTest.java:
##########
@@ -120,15 +146,55 @@ public void testAbortIgnoresMissing() throws Exception {
         runWithSyncWorker(this::callAbort);
     }
 
+    @Test
+    public void testCheckpointAbortBeforeStart() throws Exception {
+        SyncChannelStateWriteRequestExecutor worker = new 
SyncChannelStateWriteRequestExecutor();
+        ChannelStateWriterImpl writer = new ChannelStateWriterImpl(TASK_NAME, 
worker);
+        writer.open();
+        callAbort(writer);
+
+        // It should be started.

Review Comment:
   nit: this comment is a bit miss leading. `it should be started` -> `start 
after abort should be ignored`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to