swuferhong commented on code in PR #20084:
URL: https://github.com/apache/flink/pull/20084#discussion_r928355032
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java:
##########
@@ -18,90 +18,36 @@
package org.apache.flink.formats.csv;
-import org.apache.flink.table.api.TableConfig;
-import org.apache.flink.table.api.TableEnvironment;
import org.apache.flink.table.plan.stats.TableStats;
-import org.apache.flink.table.planner.plan.schema.TableSourceTable;
import org.apache.flink.table.planner.plan.stats.FlinkStatistic;
-import org.apache.flink.table.planner.utils.BatchTableTestUtil;
-import org.apache.flink.table.planner.utils.TableTestBase;
-import org.apache.flink.table.planner.utils.TableTestUtil;
-import org.apache.flink.util.Preconditions;
+import org.apache.flink.table.types.DataType;
-import org.apache.calcite.rel.RelNode;
-import org.apache.calcite.rel.RelVisitor;
-import org.apache.calcite.rel.core.TableScan;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
import java.io.File;
-import java.io.IOException;
-import java.nio.file.Files;
-import java.util.Arrays;
-import java.util.List;
+import java.util.concurrent.ExecutionException;
import static org.assertj.core.api.Assertions.assertThat;
/**
* Test for statistics functionality in {@link CsvFormatFactory} in the case
of file system source.
*/
-public class CsvFormatFilesystemStatisticsReportTest extends TableTestBase {
- private BatchTableTestUtil util;
- private TableEnvironment tEnv;
- @TempDir private static File path;
+public class CsvFormatFilesystemStatisticsReportTest extends
CsvFormatStatisticsReportTest {
Review Comment:
> Since `CsvFormatFilesystemStatisticsReportTest` extends
`CsvFormatStatisticsReportTest`, it wll also run the tests in
`CsvFormatStatisticsReportTest`. Is it expected?
Yes, the result is in line with expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
