yunfengzhou-hub commented on code in PR #20275:
URL: https://github.com/apache/flink/pull/20275#discussion_r928493949
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/OperatorCoordinatorCheckpoints.java:
##########
@@ -59,15 +66,25 @@ public static CompletableFuture<CoordinatorSnapshot>
triggerCoordinatorCheckpoin
public static CompletableFuture<AllCoordinatorSnapshots>
triggerAllCoordinatorCheckpoints(
final Collection<OperatorCoordinatorCheckpointContext>
coordinators,
- final long checkpointId)
+ final PendingCheckpoint checkpoint)
throws Exception {
final Collection<CompletableFuture<CoordinatorSnapshot>>
individualSnapshots =
new ArrayList<>(coordinators.size());
for (final OperatorCoordinatorCheckpointContext coordinator :
coordinators) {
+ Set<Integer> subtasksToCheckpoint = new HashSet<>();
Review Comment:
I agree. I'll rename it to `subtasksToWaitFor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
