yunfengzhou-hub commented on code in PR #20275:
URL: https://github.com/apache/flink/pull/20275#discussion_r931717326
##########
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinatorHolder.java:
##########
@@ -229,6 +233,7 @@ public void checkpointCoordinator(long checkpointId,
CompletableFuture<byte[]> r
// checkpoint coordinator time thread.
// we can remove the delegation once the checkpoint coordinator runs
fully in the
// scheduler's main thread executor
+
Preconditions.checkState(!context.isConcurrentExecutionAttemptsSupported());
Review Comment:
I think this check is necessary. The correctness of the current
implementation of this PR is based on the assumption that speculative execution
will not function together with Flink's checkpoint mechanism, thus it is
reasonable and critical to check that there will not be multiple execution
attempts when a checkpoint starts.
The newly added checks in other functions seem removable. I'll make
modifications to those invocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
