reswqa commented on code in PR #20371:
URL: https://github.com/apache/flink/pull/20371#discussion_r933008525


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsFileDataManager.java:
##########
@@ -176,6 +177,19 @@ public void deleteShuffleFile() {
         IOUtils.deleteFileQuietly(dataFilePath);
     }
 
+    /**
+     * Release specific {@link HsSubpartitionFileReader} from {@link 
HsFileDataManager}.
+     *
+     * @param subpartitionFileReader to release.
+     */
+    public void releaseSubpartitionReader(HsSubpartitionFileReader 
subpartitionFileReader) {
+        synchronized (lock) {
+            if (allReaders.contains(subpartitionFileReader)) {
+                failedReaders.add(subpartitionFileReader);

Review Comment:
   Simplify the logic related to release and fail reader in HsFileDataManager 
in a hot-fix commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to