reswqa commented on code in PR #20371:
URL: https://github.com/apache/flink/pull/20371#discussion_r933072775
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionFileReaderImpl.java:
##########
@@ -192,6 +198,50 @@ public Deque<BufferIndexOrError> getLoadedBuffers() {
return loadedBuffers;
}
+ @Override
+ public Optional<ResultSubpartition.BufferAndBacklog> consumeBuffer(int
nextBufferToConsume)
+ throws Throwable {
+ BufferIndexOrError current = loadedBuffers.poll();
Review Comment:
Fixed.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionFileReaderImpl.java:
##########
@@ -192,6 +198,50 @@ public Deque<BufferIndexOrError> getLoadedBuffers() {
return loadedBuffers;
}
+ @Override
+ public Optional<ResultSubpartition.BufferAndBacklog> consumeBuffer(int
nextBufferToConsume)
+ throws Throwable {
+ BufferIndexOrError current = loadedBuffers.poll();
+
+ if (current == null) {
+ return Optional.empty();
+ }
+
+ if (current.getThrowable().isPresent()) {
+ throw current.getThrowable().get();
+ }
+
+ BufferIndexOrError next = loadedBuffers.peek();
+
+ Buffer.DataType nextDataType = next == null ? Buffer.DataType.NONE :
next.getDataType();
+ int backlog = loadedBuffers.size();
+ int bufferIndex = current.getIndex();
+ Buffer buffer =
+ current.getBuffer()
+ .orElseThrow(
+ () ->
+ new NullPointerException(
+ "Get a non-throwable and
non-buffer bufferIndexOrError, which is not allowed"));
+ return Optional.of(
+ ResultSubpartition.BufferAndBacklog.fromBufferAndLookahead(
+ buffer, nextDataType, backlog, bufferIndex));
+ }
+
+ @Override
+ public Buffer.DataType peekNextToConsumeDataType(int nextBufferToConsume) {
+ return Buffer.DataType.NONE;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
