xintongsong commented on code in PR #20426:
URL: https://github.com/apache/flink/pull/20426#discussion_r937295256
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionType.java:
##########
@@ -196,4 +196,8 @@ public boolean isBounded() {
public boolean isPersistent() {
return isPersistent;
}
+
+ public boolean canBeCompressed() {
Review Comment:
```suggestion
public boolean supportCompression() {
```
##########
flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java:
##########
@@ -70,20 +70,20 @@ public class NettyShuffleEnvironmentOptions {
+ ") is set to true");
/**
- * Boolean flag indicating whether the shuffle data will be compressed for
blocking shuffle
- * mode.
+ * Boolean flag indicating whether the shuffle data will be compressed for
batch shuffle mode.
*
* <p>Note: Data is compressed per buffer and compression can incur extra
CPU overhead so it is
* more effective for IO bounded scenario when data compression ratio is
high.
*/
@Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER_NETWORK)
- public static final ConfigOption<Boolean>
BLOCKING_SHUFFLE_COMPRESSION_ENABLED =
- key("taskmanager.network.blocking-shuffle.compression.enabled")
+ public static final ConfigOption<Boolean>
BATCH_SHUFFLE_COMPRESSION_ENABLED =
+ key("taskmanager.network.batch-shuffle.compression.enabled")
.booleanType()
.defaultValue(true)
+
.withFallbackKeys("taskmanager.network.blocking-shuffle.compression.enabled")
Review Comment:
```suggestion
.withDeprecatedKeys("taskmanager.network.blocking-shuffle.compression.enabled")
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataSpiller.java:
##########
@@ -60,13 +64,17 @@ public class HsMemoryDataSpiller implements AutoCloseable {
/** File channel to write data. */
private final FileChannel dataFileChannel;
+ private final BufferCompressor bufferCompressor;
Review Comment:
Should mark `@Nullable`. Same for the corresponding constructor parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
