godfreyhe commented on code in PR #20432:
URL: https://github.com/apache/flink/pull/20432#discussion_r939509875
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/JoinITCase.scala:
##########
@@ -66,6 +68,29 @@ class JoinITCase(state: StateBackendMode) extends
StreamingWithStateTestBase(sta
.toTable(tEnv, 'b1, 'b2, 'b3, 'b4, 'b5)
tEnv.registerTable("A", tableA)
tEnv.registerTable("B", tableB)
+
+ val dataId1 = TestValuesTableFactory.registerData(TestData.data2_1)
+ tEnv.executeSql(s"""
+ |create table l (
+ | a int,
+ | b double
+ |) with (
+ | 'connector' = 'values',
+ | 'data-id' = '$dataId1',
+ | 'bounded' = 'true'
Review Comment:
not necessary, the correctness is not affected by bounded source and
unbounded source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
