yuzelin commented on code in PR #20438:
URL: https://github.com/apache/flink/pull/20438#discussion_r939666697
##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/OperationExecutorFactory.java:
##########
@@ -51,6 +56,18 @@ public static Callable<ResultSet> createGetSchemasExecutor(
return () -> executeGetSchemas(service, sessionHandle, catalogName,
schemaName);
}
+ public static Callable<ResultSet> createGetTablesExecutor(
+ SqlGatewayService service,
+ SessionHandle sessionHandle,
+ @Nullable String catalogName,
+ @Nullable String schemaName,
+ @Nullable String tableName,
+ Set<TableKind> tableKinds) {
Review Comment:
It's not Nullable because toFlinkTableKinds always gives a Nonnull set.
Maybe use @Nonnull ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
