yuzelin commented on code in PR #20438:
URL: https://github.com/apache/flink/pull/20438#discussion_r939664314


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/ThriftObjectConversions.java:
##########
@@ -617,4 +623,29 @@ private static List<String> enroll(Throwable ex, 
StackTraceElement[] trace, int
         }
         return details;
     }
+
+    public static Set<TableKind> mapToFlinkTableKinds(List<String> tableTypes)
+            throws UnsupportedOperationException {
+        Set<TableKind> tableKinds = new HashSet<>();
+
+        if (tableTypes == null || tableTypes.isEmpty()) {
+            tableKinds.add(TableKind.TABLE);
+            tableKinds.add(TableKind.VIEW);
+            return tableKinds;

Review Comment:
   Good idea. Changed.



##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/endpoint/hive/util/ThriftObjectConversions.java:
##########
@@ -617,4 +623,29 @@ private static List<String> enroll(Throwable ex, 
StackTraceElement[] trace, int
         }
         return details;
     }
+
+    public static Set<TableKind> mapToFlinkTableKinds(List<String> tableTypes)
+            throws UnsupportedOperationException {

Review Comment:
   Got it. Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to