fredia commented on code in PR #20217:
URL: https://github.com/apache/flink/pull/20217#discussion_r939796611
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/ChangelogTaskLocalStateStore.java:
##########
@@ -181,6 +226,16 @@ public void pruneCheckpoints(LongPredicate pruningChecker,
boolean breakOnceChec
@Override
public CompletableFuture<Void> dispose() {
deleteMaterialization(id -> true);
+ // delete all ChangelogStateHandle in taskowned directory.
+ discardExecutor.execute(
+ () ->
+ syncDiscardFileForCollection(
Review Comment:
Yes, this will delete other job's states.
I moved `aid_xx/taskowned` folder to `aid_xxx/jid_xxx/taskowned` to avoid
this.
> Why don't we put this logic in LocalStateRegistry - that would allow to
avoid clashing and guessing the locations
Because the `taskowned` folder needs to be deleted when `dispose()`, and
`LocalStateRegistry` can only delete the files in the folder, can't delete the
folder itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
