fredia commented on code in PR #20217:
URL: https://github.com/apache/flink/pull/20217#discussion_r940213842
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogStorage.java:
##########
@@ -104,17 +126,24 @@ public FsStateChangelogStorage(
metricGroup,
changelogRegistry)),
PREEMPTIVE_PERSIST_THRESHOLD.defaultValue().getBytes(),
- changelogRegistry);
+ changelogRegistry,
+ localRecoveryConfig);
}
@VisibleForTesting
public FsStateChangelogStorage(
StateChangeUploadScheduler uploader,
long preEmptivePersistThresholdInBytes,
- TaskChangelogRegistry changelogRegistry) {
+ TaskChangelogRegistry changelogRegistry,
+ LocalRecoveryConfig localRecoveryConfig) {
this.preEmptivePersistThresholdInBytes =
preEmptivePersistThresholdInBytes;
this.changelogRegistry = changelogRegistry;
this.uploader = uploader;
+ this.localRecoveryConfig = localRecoveryConfig;
+ if (localRecoveryConfig.isLocalRecoveryEnabled()) {
+ this.localChangelogRegistry =
+ new
LocalChangelogRegistry(Executors.newSingleThreadExecutor());
Review Comment:
This and `defaultChangelogRegistry` would create two executors for each job,
how about passing the `TaskManagerServices.ioExecutor` for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
