curcur commented on code in PR #20585:
URL: https://github.com/apache/flink/pull/20585#discussion_r946444390
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java:
##########
@@ -118,7 +118,7 @@ public void start() {
LOG.info("Task {} starts periodic materialization", subtaskName);
- scheduleNextMaterialization(periodicMaterializeDelay +
initialDelay);
+ scheduleNextMaterialization(initialDelay);
Review Comment:
So now we have `periodicMaterializationDelay`, we have `initialDelay` and we
have `periodicMaterializationDelay < 0` to indicate materialization disabled if
I understand correctly?
Isn't this so confusing and misleading to the users? What about
`initialDelay` being very big or negative?
What is the problem to introduce a flag to indicate enable/disable? I think
the original argument is that we do not want to introduce too many configs, but
I think the current way is much more confusing and problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
