rkhachatryan commented on code in PR #20585:
URL: https://github.com/apache/flink/pull/20585#discussion_r946514885
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/PeriodicMaterializationManager.java:
##########
@@ -118,7 +118,7 @@ public void start() {
LOG.info("Task {} starts periodic materialization", subtaskName);
- scheduleNextMaterialization(periodicMaterializeDelay +
initialDelay);
+ scheduleNextMaterialization(initialDelay);
Review Comment:
Sorry for the confusion, a negative value will prevent any materialization
indeed.
I think both approaches have their both pros and cons (a separate flag is
more explicit, but the user has to keep the two variables consistent).
But keeping negative value as it is doesn't change the API, so I'd chose
this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
