zentol commented on code in PR #20613:
URL: https://github.com/apache/flink/pull/20613#discussion_r947760078


##########
flink-end-to-end-tests/flink-end-to-end-tests-sql/pom.xml:
##########
@@ -199,4 +199,29 @@
             </plugin>
         </plugins>
     </build>
+
+    <profiles>
+        <!-- Activate these profiles with -Phadoop3-tests to build and test 
against hadoop 3.1.3 -->
+        <profile>
+            <id>hadoop3-tests</id>
+            <properties>
+                <flink.hadoop.version>3.1.3</flink.hadoop.version>
+            </properties>

Review Comment:
   you shouldn't set the property in the profile; it will leak to inconsistent 
behavior when we use a different Hadoop 3 version on CI.
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to