zentol commented on code in PR #20613:
URL: https://github.com/apache/flink/pull/20613#discussion_r948138118
##########
flink-end-to-end-tests/flink-end-to-end-tests-sql/pom.xml:
##########
@@ -199,4 +199,25 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <!-- This profile adds dependencies needed to execute the tests with
Hadoop 3 -->
+ <profile>
+ <id>hadoop3-tests</id>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-hdfs-client</artifactId>
+ <version>${flink.hadoop.version}</version>
+ <scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>jackson-annotations</artifactId>
Review Comment:
I'm not sure if that's a good idea. At the end of the day hadoop 3 has a
different dependency tree, and trying to keep the close may just cause problems
in the future when something suddenly stops working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
