ASF GitHub Bot commented on FLINK-4609:

Github user fhueske commented on a diff in the pull request:

    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
    @@ -971,10 +971,7 @@ public void 
testForwardWithAtLeastOneIterationAssumptionForJavac() {
                public void reduce(Iterable<Tuple2<Long, Long>> values, 
Collector<Long> out) throws Exception {
                        Long id = 0L;
                        for (Tuple2<Long, Long> value : values) {
    -                           id = value.f0;
    --- End diff --
    This change causes a test to fail and should be reverted.
    The UdfAnalyzer is a component that inspects the bytecode of user-defined 
functions to infer how they access input values. By removing the if condition 
(which is not evaluated by the analyzer), the analyzer can better infer the 
behavior of the function produces a different output.

> Remove redundant check for null in CrossOperator
> ------------------------------------------------
>                 Key: FLINK-4609
>                 URL: https://issues.apache.org/jira/browse/FLINK-4609
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 1.1.2
>            Reporter: Alexander Pivovarov
>            Priority: Trivial
> CrossOperator checks input1 and input2 for null after they were dereferenced

This message was sent by Atlassian JIRA

Reply via email to