[ 
https://issues.apache.org/jira/browse/FLINK-4609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15504238#comment-15504238
 ] 

ASF GitHub Bot commented on FLINK-4609:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2490
  
    Playing Devil's advocate here:
    
    Does this really improve anything meaningful? This is an API-level 
operator, not anything runtime related, so the additional null check is not 
really important. The code is not getting simpler in my opinion as well. It 
worked well before, and every change may introduce another bug.
    
    Why not focus energies on improvements where the system really gains?


> Remove redundant check for null in CrossOperator
> ------------------------------------------------
>
>                 Key: FLINK-4609
>                 URL: https://issues.apache.org/jira/browse/FLINK-4609
>             Project: Flink
>          Issue Type: Bug
>          Components: Java API
>    Affects Versions: 1.1.2
>            Reporter: Alexander Pivovarov
>            Priority: Trivial
>
> CrossOperator checks input1 and input2 for null after they were dereferenced



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to