twalthr commented on code in PR #20635:
URL: https://github.com/apache/flink/pull/20635#discussion_r952233096
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/FunctionITCase.java:
##########
@@ -159,6 +159,22 @@ public void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ public void testExpressionReducerByUsingJar() {
Review Comment:
We should avoid code deduplication in the code base. Most paths around
functions are identical for both batch and streaming. So I don't think we need
dedicated tests for `batch/sql/FunctionITCase`. What do you think about
removing `batch/sql/FunctionITCase` entirely (my recommendation) or at have
just one basic feature test in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
