lsyldliu commented on code in PR #20635:
URL: https://github.com/apache/flink/pull/20635#discussion_r952421359
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/FunctionITCase.java:
##########
@@ -159,6 +159,22 @@ public void testUsingAddJar() throws Exception {
"drop function lowerUdf");
}
+ @Test
+ public void testExpressionReducerByUsingJar() {
Review Comment:
Yes, I agree with you that we should avoid code deduplication, but I prefer
the latter, we should have one test to prove it works in batch mode. BTW, maybe
there exists some batch exclusive test in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
