masteryhx commented on code in PR #20523:
URL: https://github.com/apache/flink/pull/20523#discussion_r955729061
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChangelogStorageFactory.java:
##########
@@ -45,4 +51,16 @@ StateChangelogStorage<?> createStorage(
/** Create the storage for recovery. */
StateChangelogStorageView<?> createStorageView(Configuration
configuration) throws IOException;
+
+ /** Extract the relevant to this factory portion of the configuration. */
+ default Configuration extractConfiguration(ReadableConfig src) {
Review Comment:
IIUC, Even if users haven't setted these parameter in job level, we will
still overide them in current logic?
Should we just overide them when users have setted them ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
